Set upper and lower interpolation bounds for MGXS data.#3803
Merged
Conversation
GuySten
reviewed
Feb 12, 2026
GuySten
reviewed
Feb 14, 2026
nuclearkevin
force-pushed
the
set_data_bnds_mg
branch
from
February 14, 2026 23:58
26be49a to
9fe9422
Compare
nuclearkevin
force-pushed
the
set_data_bnds_mg
branch
from
February 15, 2026 00:02
43fcf8e to
36da8d0
Compare
GuySten
added
Merging Soon
GuySten
requested changes
Feb 15, 2026
GuySten
approved these changes
Feb 15, 2026
GuySten
added
the
Merging Soon
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running OpenMC with the C/C++ API in multi-group mode, an error will get thrown when cell temperatures are set with
openmc_cell_set_temperature(...):The error is caused by
data::temperature_minanddata::temperature_maxnot being set when loading multi-group cross sections. This PR adds a code block to compute the minimum and maximum values, which fixes a longstanding bug in Cardinal.Combining this fix with some changes in Cardinal (clearing and reloading MGXS after temperatures are set) part of the fix for #2402
FYI @meltawila, @aprilnovak
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)